Skip to content

gh-130607: Extend and cleanup IPv6 tests #121518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 28, 2025
Merged

gh-130607: Extend and cleanup IPv6 tests #121518

merged 8 commits into from
Feb 28, 2025

Conversation

@bazhil
Copy link
Contributor

@bazhil bazhil commented Jul 8, 2024 •
edited by bedevere-app bot
Loading

  1. Was added two test cases for IPv6 with part of IPv4.
  2. Add space in two lines (896, 897) between variable and '='

Hope this work make ipaddress better.

@ghost
Copy link

ghost commented Jul 8, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jul 8, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 8, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jul 8, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bazhil bazhil changed the title Extend IPv6 tests and made little syntax refactoring Extend IPv6 tests and made little syntax refactoring skip issue skip news Jul 8, 2024
@bazhil bazhil changed the title Extend IPv6 tests and made little syntax refactoring skip issue skip news Extend IPv6 tests and made little syntax refactoring #skip issue #skip news Jul 8, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Feb 25, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

picnixz
picnixz reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still want an issue for refactoring this but a skip news is fine. The issue should indicate which tests need to be refactored (essentially all those using == + assertTrue/False; we should use better assert methods) and why some need to be extended.

We can however improve even the testsdoing == by using assertEqual. Traceback will be nicer.

@picnixz picnixz changed the title Extend IPv6 tests and made little syntax refactoring #skip issue #skip news Extend and cleanup IPv6 tests Feb 25, 2025
@bazhil
Copy link
Contributor Author

bazhil commented Feb 26, 2025

@picnixz create an issue for this pull request #130607

@bazhil bazhil changed the title Extend and cleanup IPv6 tests [3.12] gh-130607: Extend and cleanup IPv6 tests Feb 26, 2025
@bazhil bazhil changed the title [3.12] gh-130607: Extend and cleanup IPv6 tests gh-130607: Extend and cleanup IPv6 tests Feb 26, 2025
encukou
encukou approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is an improvement; any refactoring can be done in a separate PR.

StanFromIreland
StanFromIreland approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

@StanFromIreland
Copy link
Member

You do not need to update the branch. That will
done by whoever is committing it.

@encukou encukou merged commit 9f0879b into python:main Feb 28, 2025
38 checks passed
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 28, 2025
@miss-islington-app
Copy link

Thanks @bazhil for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @bazhil for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 28, 2025
@bazhil @miss-islington
pythongh-130607: Extend and cleanup IPv6 tests (pythonGH-121518)
8b67270 
Extend IPv6 tests and made little syntax refactoring
(cherry picked from commit 9f0879b)

Co-authored-by: Ilya Bazhenov <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 28, 2025

GH-130678 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 28, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 28, 2025
@bazhil @miss-islington
pythongh-130607: Extend and cleanup IPv6 tests (pythonGH-121518)
855c57e 
Extend IPv6 tests and made little syntax refactoring
(cherry picked from commit 9f0879b)

Co-authored-by: Ilya Bazhenov <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 28, 2025

GH-130679 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 28, 2025
encukou pushed a commit that referenced this pull request Feb 28, 2025
@miss-islington @bazhil
[3.12] gh-130607: Extend and cleanup IPv6 tests (GH-121518) (GH-130678)
d922aa8 
Extend IPv6 tests and made little syntax refactoring
(cherry picked from commit 9f0879b)

Co-authored-by: Ilya Bazhenov <[email protected]>
encukou pushed a commit that referenced this pull request Feb 28, 2025
@miss-islington @bazhil
[3.13] gh-130607: Extend and cleanup IPv6 tests (GH-121518) (GH-130679)
9d825d4 
Extend IPv6 tests and made little syntax refactoring
(cherry picked from commit 9f0879b)

Co-authored-by: Ilya Bazhenov <[email protected]>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@bazhil @seehwan80
pythongh-130607: Extend and cleanup IPv6 tests (pythonGH-121518)
d048398 
Extend IPv6 tests and made little syntax refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@encukou encukou encukou approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bazhil @StanFromIreland @encukou @picnixz